4 bit multiplier with negative numbers

posted by MadLunatic12 on Sun, 2024-08-04 16:43
Build image: 
In-game name (NO VISITORS! Must be LEARNER rank or higher!): 
MadLunatic12
Builder name(s) and current ranks: 
MadLunatic12(L+)Allex253(L+)
Creation location: 
475 43 466
Machine Features: 

3 Digit display with negative indicator, input isn't binary it is a bunch of al possible 4 bit numbers on a wall

How To Use: 

Flick the levers to multiply. Calculation time averages about 4-5 secs.

Request status: 
Not approved

Comments

On Mon, 2024-08-05 15:58

Good start :)
But there are features to add and logic to improve.

Besides that: If you make a PR together, it is important for the judges to know who built/designed which part (together is fine). Also if you got help or copied something from someone else, this needs to be mentioned. The Double Dabble unit looks like someone donated it to your building (which is fine, but we need to know that).

Following the challenge description shown here '/challenges regular 2', you have to at least add addition and subtraction as mathematical operations. Your output is nice. As for your input, you currently are using 15 inputs, which is fine. A simple way to improve this is to use 0-9 as input and a '+10' option.

List of things contributing to passing this PR:

Challenge must have features:

  • Add addition and subtraction operations

Mechanics you should improve:

  • Your input system uses levers. You should use buttons instead, that allows for a much easier input. Pressing one will "unpress" the previous value. (Also use buttons to choose which operation is currently active).
  • Your decoder converting BCD to decimal is chaining repeaters, this contributes to a flickering display. For higher ranks you have to build synchronized decoders, I highly recommend learning how to build them and use it for this challenge.

Things you could improve:

  • Your input system could use only 10 buttons for the digits 0 to 9 and an additional +10 lever or preferably toggle button.
  • You could show the input numbers on a display and only use a single number input console allowing to change both input numbers.

Feel free to ask questions for this feedback on our Discord, they will be answered :)

By Ecconia